Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix add-ons permissions breaking change #15002

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Fix add-ons permissions breaking change #15002

merged 2 commits into from
Sep 17, 2020

Conversation

Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Sep 11, 2020 •
edited
Loading

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Amejia481 Amejia481 mentioned this pull request Sep 11, 2020
Merged
4 tasks
bors bot pushed a commit to mozilla-mobile/android-components that referenced this pull request Sep 16, 2020
@MozLando @Amejia481
Merge #8388
30dacc6 
8388: Closes #8323: Add-on permission dialog does not prompt  for host permissions r=rocketsroger,delphine a=Amejia481

Adapted algorithm from the [desktop implementation](https://searchfox.org/mozilla-central/source/toolkit/components/extensions/Extension.jsm#1488-1568) docs related to host permissions [[1]](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions#Host_permissions) [[2]](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns)

Fenix pr mozilla-mobile/fenix#15002



Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
@Amejia481 Amejia481 mentioned this pull request Sep 17, 2020
Closed
@Amejia481 Amejia481 force-pushed the fix_add_ons_permissions_breaking_change branch from 5f2edb7 to 9bcbe63 Compare September 17, 2020 15:25
@codecov-commenter
Copy link

Codecov Report

Merging #15002 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #15002      +/-   ##
============================================
+ Coverage     29.22%   29.23%   +0.01%     
- Complexity     1161     1162       +1     
============================================
  Files           454      454              
  Lines         18561    18558       -3     
  Branches       2394     2394              
============================================
+ Hits           5424     5425       +1     
+ Misses        12760    12756       -4     
  Partials        377      377
Impacted Files Coverage Δ Complexity Δ
...ozilla/fenix/addons/AddonPermissionsDetailsView.kt 100.00% <100.00%> (+12.50%) 5.00 <0.00> (ø)
...mponents/searchengine/FenixSearchEngineProvider.kt 63.96% <0.00%> (+1.80%) 14.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f036d3d...9bcbe63. Read the comment docs.

@Amejia481
Copy link
Contributor Author

This is ready to land!

ekager
ekager approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@ekager ekager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

@ekager ekager merged commit d3d24c0 into mozilla-mobile:master Sep 17, 2020
@Amejia481
Copy link
Contributor Author

Thanks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ekager ekager ekager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amejia481 @codecov-commenter @ekager